List to go through prior submitting your MR for a review.
Ā
Gitlab MR itself
Necessary Information (Title, pipeline, ..)
Title
- format āFeat/69420-contact-pageā
- keyword āFeatā, āBugfixā or āRefactorā, followed by slash & Redmineās taskās number and description
Description
- Description mentions code changes, new features, and any other information relevant for reviewer
- Screenshot of changes in UI (if applicable)
- Description should also mention Redmine task in format `Relates #69420` or `References #69420` (this directly links to Redmine)
Pipeline
- pipeline should successfully pass (green light)
- if failed, investigate cause, refator/fix issues and run the job again
Branch
- up to date with parent
- no conflicts
Ā
Imports
Decomposition
- custom hooks for a chunk of logic/separate component
Correct types, type decomposition, type errors
Obsolete code
- forgotten console.logs
- irrelavant logic
- unused imports/variables/functions/files
Styling
Relevant translations commits
Following naming conventions
Ā
Ā
Ā
Ā
Ā
Code
- Imports - make sense?
- Decomposition - custom hooks for a chunk of logic/separate component
- Correct types, type decomposition, type errors
- Obsolete code - forgotten logs, irrelevant logic, unused imports/variables/functions/files
- Inline styling
- Committed relevant locales
- Followed naming conventions